Maria-Berta opened a new pull request, #1253: URL: https://github.com/apache/arrow-java/pull/1253
### Rationale for this change ComplexCopier did not support copying FixedSizeBinary columns nested in List, Map, Struct, or top-level contexts, throwing UnsupportedOperationException. ### What changes are included in this PR? Adds FIXEDSIZEBINARY cases to: - getListWriterForReader - getStructWriterForReader - getMapWriterForReader - the main copy() switch ### Are these changes tested? Yes: - testCopyListOfFixedSizeBinary — copying a List<FixedSizeBinary> - testCopyStructOfFixedSizeBinary — copying a Struct field of type FixedSizeBinary Full TestComplexCopier suite (22 tests) passes with no regressions. Note: I attempted to add equivalent coverage for Map values of type FixedSizeBinary, but ran into a pre-existing limitation unrelated to this fix — MapWriter/ListWriter's no-arg fixedSizeBinary() delegates to NullableStructWriter.fixedSizeBinary(String), which only looks up an existing child writer and never creates one. The byteWidth-aware overload that does create the vector isn't reachable through the public MapWriter/ListWriter interface. This appears to be a gap in the writer codegen itself rather than something ComplexCopier can work around, so I've left it untested here — happy to open a follow-up issue if that's useful, or take a stab at it if maintainers think it's in scope for this PR. Closes #559 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
