thisisnic commented on PR #50525: URL: https://github.com/apache/arrow/pull/50525#issuecomment-5169821394
Thanks for the explanation and the time and effort put into working on this. After having a proper think, sorry @olivroy, but I'm against merging this as the risks outweigh the benefits: - many of those rlang type checking functions are flagged as experimental meaning ["the author reserves the right to make breaking changes without a deprecation cycle"](https://lifecycle.r-lib.org/articles/stages.html#experimental). FWIW, if they were stable, I'd be in favour of switching to using them. - although this does reduce our number of dependencies, assertthat is old but stable and is a tiny dependency so the impact is minimal - I'm also opposed to copying in functions from another package, instead of using its exported functions. We have no way of knowing if those functions get updated later other than checking manually, and using existing exported functions means we can rely on the package's tests too -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
