Jefffrey commented on code in PR #10057:
URL: https://github.com/apache/arrow-rs/pull/10057#discussion_r3708938039
##########
arrow-select/src/coalesce.rs:
##########
@@ -722,17 +722,25 @@ trait InProgressArray: std::fmt::Debug + Send + Sync {
/// Copy rows from the current source array into the in-progress array
///
- /// The source array is set by [`Self::set_source`].
+ /// Note: The source array is set by [`Self::set_source`].
///
/// Return an error if the source array is not set
fn copy_rows(&mut self, offset: usize, len: usize) -> Result<(),
ArrowError>;
/// Copy rows selected by `filter` from the current source array.
+ ///
+ /// The default implementation calls [`Self::copy_rows_by_selection`]
fn copy_rows_by_filter(&mut self, filter: &FilterPredicate) -> Result<(),
ArrowError> {
self.copy_rows_by_selection(filter.selection())
}
- /// Copy rows selected by `filter` from `source`.
+ /// Copy rows selected by a [`FilterPredicate`] from `source`.
+ ///
+ /// Unlike the other copy methods, the source array is passed in directly
+ /// rather than read from the array set by [`Self::set_source`].
+ ///
+ /// The default implementation sets `source` via [`Self::set_source`] and
+ /// then calls [`Self::copy_rows_by_filter`].
Review Comment:
this bit reads a bit odd, since its both saying "we dont read from
set_source" but "by default we'll use set_source"
maybe need to emphasize that not reading from `set_source` allows more
flexibility, but the default will still just use `set_source`, to clarify this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
