hiroyuki-sato opened a new pull request, #50798:
URL: https://github.com/apache/arrow/pull/50798

   ### Rationale for this change
   
   This is the sub issue #44748.
   
   * SC2046: Quote this to prevent word splitting.
   * SC2086: Double quote to prevent globbing and word splitting.
   * SC2223: This default assignment may cause DoS due to globbing. Quote it.
   
   ```
   shellcheck ci/scripts/r_valgrind.sh
   
   In ci/scripts/r_valgrind.sh line 21:
   : ${R_BIN:=RDvalgrind}
     ^------------------^ SC2223 (info): This default assignment may cause DoS 
due to globbing. Quote it.
   
   
   In ci/scripts/r_valgrind.sh line 27:
   pushd ${source_dir}
         ^-----------^ SC2086 (info): Double quote to prevent globbing and word 
splitting.
   
   Did you mean:
   pushd "${source_dir}"
   
   
   In ci/scripts/r_valgrind.sh line 31:
   ${R_BIN} CMD INSTALL ${INSTALL_ARGS} arrow*.tar.gz
                        ^-------------^ SC2086 (info): Double quote to prevent 
globbing and word splitting.
   
   Did you mean:
   ${R_BIN} CMD INSTALL "${INSTALL_ARGS}" arrow*.tar.gz
   
   
   In ci/scripts/r_valgrind.sh line 42:
   if [ $(grep -c "ERROR SUMMARY: 0 errors" testthat.out) != 1 ]; then
        ^-- SC2046 (warning): Quote this to prevent word splitting.
   
   For more information:
     https://www.shellcheck.net/wiki/SC2046 -- Quote this to prevent word 
splitt...
     https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent globbing 
...
     https://www.shellcheck.net/wiki/SC2223 -- This default assignment may 
cause...
   ```
   
   
   ### What changes are included in this PR?
   
   * SC2046: Quote variable to prevent word splitting.
   * SC2086: Quote variable
   * SC2223: Quote default variable assignments.
   
   ### Are these changes tested?
   
   Yes.
   
   ### Are there any user-facing changes?
   
   No.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to