Copilot commented on code in PR #50802:
URL: https://github.com/apache/arrow/pull/50802#discussion_r3710918299
##########
python/pyarrow/_acero.pyx:
##########
@@ -79,6 +79,31 @@ class TableSourceNodeOptions(_TableSourceNodeOptions):
self._set_options(table)
+cdef class _RecordBatchReaderSourceNodeOptions(ExecNodeOptions):
+
+ def _set_options(self, RecordBatchReader reader):
+ self.wrapped.reset(
+ new CRecordBatchReaderSourceNodeOptions(reader.reader)
+ )
+
+
+class RecordBatchReaderSourceNodeOptions(_RecordBatchReaderSourceNodeOptions):
+ """
+ A Source node which streams data from a RecordBatchReader.
+
+ This is the option class for the "record_batch_reader_source" node
+ factory.
Review Comment:
The PR description currently flags "breaking changes" and a "critical fix",
but the diff here appears to only add a new Python-exposed options class plus
tests/docs (an additive change). Please either explain the breaking/critical
aspects in the PR description or remove those statements to avoid misleading
release notes/reviewers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
