alamb opened a new pull request, #10545: URL: https://github.com/apache/arrow-rs/pull/10545
# Which issue does this PR close? - Part of https://github.com/apache/arrow-rs/issues/10540 # Rationale for this change I am trying to understand the depth of our round trip tests (there are over 4000 lines of tests in the arrow writer module). After some study it appears there are tests to round trip both single columns and record batches, which share some non trivial amount of logic. It also makes it hard to evaluate coverage because there are several similar but not quite the same free functions and it is unclear hwo they are related to each other and what some of the parameters mean (like the argument to `roundtrip_one_column`) I think making it easier to find and evaluate test coverage will make it easier to maintain and extend this crate in the future. # What changes are included in this PR? 1. Move round trip logic into methods on `RoundTripTest` rather than free functions # Are these changes tested? Only tests # Are there any user-facing changes? No -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
