emilk opened a new pull request, #10552: URL: https://github.com/apache/arrow-rs/pull/10552
# Which issue does this PR close? No issue in particular - Follow-up to #10533 - Related to #10458 # Rationale for this change #10533 added `[workspace.lints]` with a minimal set of lints. This fills out `[workspace.lints.clippy]` with lints from [egui's `Cargo.toml`](https://github.com/emilk/egui/blob/main/Cargo.toml). # What changes are included in this PR? The first commit enables the 46 lints that have zero violations, so it is config only. After that, one commit per lint, each with its fixes: - `assigning_clones`, `comparison_chain`, `manual_midpoint` (1 violation each) - `large_stack_arrays`, `tuple_array_conversions`, `single_option_map` (2 each) Only lints that already exist in the `rust-version = "1.88"` MSRV are used, so building at MSRV does not produce `unknown lint` warnings. Lints that are warn-or-deny by default are left out, since CI's `-D warnings` already enforces those. `manual_midpoint` caught a real (if unreachable) overflow: `(min + max) / 2` in the CDC chunker is now `i64::midpoint`. More lints can follow in later PRs; ~87 of egui's clippy lints still have violations here. # Are these changes tested? Yes, by existing CI. `cargo clippy --workspace --all-targets --all-features` is at zero warnings after every individual commit, and the tests of each affected crate pass. # Are there any user-facing changes? No public API changed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
