lidavidm commented on code in PR #4645:
URL: https://github.com/apache/arrow-adbc/pull/4645#discussion_r3717436732
##########
c/driver/framework/base_driver.h:
##########
@@ -169,11 +169,19 @@ class Option {
return std::visit(
[&](auto&& value) -> AdbcStatusCode {
using T = std::decay_t<decltype(value)>;
- if constexpr (std::is_same_v<T, std::string>) {
- size_t value_size_with_terminator = value.size() + 1;
+ if constexpr (std::is_same_v<T, std::string> || std::is_same_v<T,
int64_t>) {
+ std::string formatted;
+ std::string_view string_value;
+ if constexpr (std::is_same_v<T, std::string>) {
+ string_value = value;
+ } else {
+ formatted = std::to_string(value);
+ string_value = formatted;
Review Comment:
Looks like we need GCC11 as a baseline. I believe that's OK: AlmaLinux etc.
can install a newer GCC toolchain, and Ubuntu 22.04 has GCC11.
https://github.com/apache/arrow/pull/14666
https://stackoverflow.com/questions/63963961/what-is-the-correct-way-to-call-stdto-chars
https://gcc.gnu.org/onlinedocs/libstdc++/manual/status.html#status.iso.2017
And for clang, we need clang14 (if I understand this table right)
https://libcxx.llvm.org/Status/Cxx17.html
I believe that's supported since macOS 13, which is already EOL. But
conda-forge may complain. The minimum is only [macOS
11](https://conda-forge.org/news/2026/02/06/macOS-11/). We mark our packages as
requiring macOS 12 due to Golang. And the next version of Go will also require
13. So maybe this is OK.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
