adamreeve commented on code in PR #379: URL: https://github.com/apache/arrow-dotnet/pull/379#discussion_r3717849198
########## src/Apache.Arrow.Compute/Aggregations.cs: ########## @@ -0,0 +1,407 @@ +// Licensed to the Apache Software Foundation (ASF) under one or more +// contributor license agreements. See the NOTICE file distributed with +// this work for additional information regarding copyright ownership. +// The ASF licenses this file to You under the Apache License, Version 2.0 +// (the "License"); you may not use this file except in compliance with +// the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, software +// distributed under the License is distributed on an "AS IS" BASIS, +// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +// See the License for the specific language governing permissions and +// limitations under the License. + +using System; +#if NET8_0_OR_GREATER +using System.Numerics; +using System.Numerics.Tensors; +#endif + +namespace Apache.Arrow.Compute +{ + /// <summary> + /// Aggregation kernels over <see cref="PrimitiveArray{T}"/> (Sum/Min/Max/Mean). + /// </summary> + /// <remarks> + /// <para> + /// Null entries are skipped and do not contribute to the result. <c>Sum</c>, <c>Min</c>, + /// <c>Max</c> and <c>Mean</c> return <c>null</c> (<see cref="System.Nullable{T}"/>) when the + /// array is empty or contains no non-null elements, matching Arrow's <c>ScalarAggregateOptions</c> + /// default (<c>min_count = 1</c>) and PyArrow's compute module, which return null in these cases. Review Comment: It's not clear here that "Arrow" is actually referring to the C++ implementation. I think this is probably more detail than is needed though, this part of the sentence could just be removed: ```suggestion /// array is empty or contains no non-null elements. ``` Or if you'd like to keep this, it should say "C++ Arrow" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
