Copilot commented on code in PR #50629:
URL: https://github.com/apache/arrow/pull/50629#discussion_r3721463822
##########
cpp/src/parquet/column_reader.h:
##########
@@ -63,52 +63,63 @@ struct PARQUET_EXPORT DataPageStats {
std::optional<int32_t> num_rows;
};
+/// Decoder for repetition of definition level.
+///
+/// This decoder is used with either a deprecated bit packed (`BIT_PACKED = 4`)
+/// encoding or a mixed bit packed and RLE one (`RLE = 3`).
+/// Because it take as input a single buffer, `SetData` and `Decode` are
typically
+/// used on each of the parquet `DataPage`.
+/// The number of levels is guaranteed to fit into an `int32_t` by the
specification.
Review Comment:
Doc comment has a few typos/wording issues ("repetition of definition
level", "it take", and inconsistent "parquet" capitalization) that make the
public header read oddly.
This issue also appears on line 96 of the same file.
##########
cpp/src/parquet/level_decoder.h:
##########
@@ -0,0 +1,190 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+#pragma once
+
+#include <cstdint>
+#include <variant>
Review Comment:
`PageLevelDecoder` uses `std::min` (and other `<algorithm>` utilities) but
the header doesn’t include `<algorithm>`, which can break compilation depending
on transitive includes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
