sdf-jkl commented on code in PR #10157:
URL: https://github.com/apache/arrow-rs/pull/10157#discussion_r3723033742
##########
parquet-variant-compute/src/type_conversion.rs:
##########
@@ -287,6 +444,269 @@ where
}
}
+/// Return the unscaled integer representation for Arrow decimal type `O` from
a `Variant`.
+///
+/// Unlike `variant_to_unscaled_decim`, this function never rescales the
decimal value.
+/// It only returns the unscaled integer representation for the specific
decimal variants.
Review Comment:
```suggestion
/// Returns the unscaled integer representation for Arrow decimal type `O`
from a `Variant`.
///
/// Unlike `variant_to_unscaled_decimal`, this function only accepts integer
and decimal
/// variants. Decimal values may be rescaled only when the conversion is
exact, as verified
/// by converting the result back to the original scale.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
