ritchie46 commented on a change in pull request #296:
URL: https://github.com/apache/arrow-rs/pull/296#discussion_r633094815
##########
File path: arrow/src/compute/kernels/filter.rs
##########
@@ -221,6 +223,23 @@ pub fn build_filter(filter: &BooleanArray) ->
Result<Filter> {
/// # }
/// ```
pub fn filter(array: &Array, filter: &BooleanArray) -> Result<ArrayRef> {
+ if filter.null_count() > 0 {
+ // this greatly simplifies subsequent filtering code
+ // now we only have a boolean mask to deal with
+ let array_data = filter.data_ref();
+ let null_bitmap = array_data.null_buffer().unwrap();
Review comment:
Good catch.
##########
File path: arrow/src/compute/kernels/filter.rs
##########
@@ -221,6 +223,23 @@ pub fn build_filter(filter: &BooleanArray) ->
Result<Filter> {
/// # }
/// ```
pub fn filter(array: &Array, filter: &BooleanArray) -> Result<ArrayRef> {
+ if filter.null_count() > 0 {
+ // this greatly simplifies subsequent filtering code
+ // now we only have a boolean mask to deal with
+ let array_data = filter.data_ref();
+ let null_bitmap = array_data.null_buffer().unwrap();
Review comment:
I used `buffer_bin_and`, I assume it does a "binary and" operation?
##########
File path: arrow/src/compute/kernels/filter.rs
##########
@@ -221,6 +223,23 @@ pub fn build_filter(filter: &BooleanArray) ->
Result<Filter> {
/// # }
/// ```
pub fn filter(array: &Array, filter: &BooleanArray) -> Result<ArrayRef> {
+ if filter.null_count() > 0 {
+ // this greatly simplifies subsequent filtering code
+ // now we only have a boolean mask to deal with
+ let array_data = filter.data_ref();
+ let null_bitmap = array_data.null_buffer().unwrap();
Review comment:
I used `buffer_bin_and`, I assume it does a "binary and" operation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
