Copilot commented on code in PR #50826:
URL: https://github.com/apache/arrow/pull/50826#discussion_r3729234853
##########
format/Schema.fbs:
##########
@@ -395,42 +395,50 @@ table Timestamp {
timezone: string;
}
-enum IntervalUnit: short { YEAR_MONTH, DAY_TIME, MONTH_DAY_NANO}
-// A "calendar" interval which models types that don't necessarily
-// have a precise duration without the context of a base timestamp (e.g.
-// days can differ in length during day light savings time transitions).
-// All integers in the types below are stored in the endianness indicated
-// by the schema.
-//
-// YEAR_MONTH - Indicates the number of elapsed whole months, stored as
-// 4-byte signed integers.
-// DAY_TIME - Indicates the number of elapsed days and milliseconds (no leap
seconds),
-// stored as 2 contiguous 32-bit signed integers (8-bytes in total). Support
-// of this IntervalUnit is not required for full arrow compatibility.
-// MONTH_DAY_NANO - A triple of the number of elapsed months, days, and
nanoseconds.
-// The values are stored contiguously in 16-byte blocks. Months and days are
-// encoded as 32-bit signed integers and nanoseconds is encoded as a 64-bit
-// signed integer. Nanoseconds does not allow for leap seconds. Each field is
-// independent (e.g. there is no constraint that nanoseconds have the same
-// sign as days or that the quantity of nanoseconds represents less than a
-// day's worth of time).
+/// The unit of an Interval.
+///
+/// All integers in the units below are stored in the endianness indicated
+/// by the schema.
+enum IntervalUnit: short {
+ /// Indicates the number of elapsed whole months, stored as
+ /// 4-byte signed integers.
+ YEAR_MONTH,
+
+ /// Indicates the number of elapsed days and milliseconds (no leap seconds),
+ /// stored as 2 contiguous 32-bit signed integers (8-bytes in total). Support
+ /// of this IntervalUnit is not required for full arrow compatibility.
Review Comment:
In generated docs this will now read "full arrow compatibility"; Arrow is a
proper noun and is capitalized elsewhere in the format docs.
This issue also appears in the following locations of the same file:
- line 422
- line 439
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
