zeroshade commented on code in PR #1108:
URL: https://github.com/apache/arrow-go/pull/1108#discussion_r3737728614
##########
arrow/scalar/scalar.go:
##########
@@ -802,12 +772,20 @@ func MakeArrayFromScalar(sc Scalar, length int, mem
memory.Allocator) (arrow.Arr
return MakeArrayOfNull(sc.DataType(), length, mem), nil
}
- createOffsets := func(valLength int32) *memory.Buffer {
+ createOffsets := func(valLength int64) *memory.Buffer {
buffer := memory.NewResizableBuffer(mem)
- buffer.Resize(arrow.Int32Traits.BytesRequired(length + 1))
+ if sc.DataType().ID() == arrow.LARGE_BINARY ||
sc.DataType().ID() == arrow.LARGE_STRING {
Review Comment:
do we also need to check for LARGE_LIST?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
