lyne7-sc opened a new pull request, #10594:
URL: https://github.com/apache/arrow-rs/pull/10594
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and
enhancements and this helps us generate change logs for our releases. You can
link an issue to this PR using the GitHub syntax.
-->
- Closes #NNN.
# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in
the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your
changes and offer better suggestions for fixes.
-->
ArrayFormatter currently reparses custom Chrono format strings for every
temporal value.
As an ArrayFormatter is typically created once and reused for an array, the
parsed format items can instead be prepared once when constructing the
formatter and reused for every value.
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is
sometimes worth providing a summary of the individual changes in this PR.
-->
- Precompile custom temporal format strings when constructing an
ArrayFormatter
- Reuse the compiled format items for date, time, and timestamp values
- Add benchmarks covering default and custom temporal formats
# Are these changes tested?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are
they covered by existing tests)?
If this PR claims a performance improvement, please include evidence such as
benchmark results.
-->
Yes.
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be
updated before approving the PR.
If there are any breaking changes to public APIs, please call them out.
-->
No. There are no public API or behavior changes.
# Benchmarks
```
group main
optimized
----- ----
---------
format_temporal/date64/custom_long 1.79 1559.4±47.26µs ?
?/sec 1.00 872.7±32.05µs ? ?/sec
format_temporal/date64/custom_short 1.68 797.6±39.91µs ?
?/sec 1.00 473.7±15.21µs ? ?/sec
format_temporal/date64/default 1.02 464.7±12.82µs ?
?/sec 1.00 454.9±8.67µs ? ?/sec
format_temporal/timestamp/custom_long 1.77 1635.8±175.75µs ?
?/sec 1.00 925.6±29.74µs ? ?/sec
format_temporal/timestamp_tz/custom_long 1.54 1939.6±42.35µs ?
?/sec 1.00 1259.3±41.78µs ? ?/sec
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
