Abhisheklearn12 opened a new pull request, #10596: URL: https://github.com/apache/arrow-rs/pull/10596
# Which issue does this PR close? <!-- We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. --> None. Split out of #10436 at review request, so these land on main first and the bot can measure that PR against them. # Rationale for this change <!-- Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed. Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes. --> `cast_kernels` has one dictionary to view benchmark, at 10,000 rows over 3 values. Nothing covers the opposite shape, a dictionary much larger than the array, and nothing covers `dict<binary> -> utf8view`, which validates the values as UTF-8. # What changes are included in this PR? <!-- There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR. --> Two benchmarks, both 1024 rows over 32,768 values: - `cast dict to string view (sparse)`. For #10436 this is a no regression check rather than an expected win, since main already takes the direct path at this shape - `cast binary dict to string view (sparse)`. No dense counterpart, since that shape runs the same code either way Keys come from `seedable_rng` so they spread across the dictionary, and values exceed 12 bytes so the views reference the buffer rather than inlining. # Are these changes tested? <!-- We typically require tests for all PRs in order to: 1. Prevent the code from being accidentally broken by subsequent changes 2. Serve as another way to document the expected behavior of the code If tests are not included in your PR, please explain why (for example, are they covered by existing tests)? If this PR claims a performance improvement, please include evidence such as benchmark results. --> Benchmarks only, no library code touched. They build and run under `cargo bench -p arrow --features test_utils --bench cast_kernels`. # Are there any user-facing changes? <!-- If there are user-facing changes then we may require documentation to be updated before approving the PR. If there are any breaking changes to public APIs, please call them out. --> No. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
