YUZHEthefool opened a new issue, #10599:
URL: https://github.com/apache/arrow-rs/issues/10599
### Is your feature request related to a problem or challenge?
`arrow_ord::rank` gained a `Utf8View`/`BinaryView` path (`byte_view_rank`)
in #10559, but the rank benchmarks in `arrow/benches/sort_kernel.rs` were not
updated. They only cover the `primitive_rank` path (f32) and the `bytes_rank`
path (string[10]), so the new view
path has no benchmark coverage.
The `sort` / `sort_to_indices` benchmarks in the same file already cover
`string_view`, so `rank` is inconsistent with the rest of the sort kernel
family.
### Describe the solution you'd like
Add `rank string_view[10]` and `rank string_view[0-400]` benchmarks (each
with and without nulls) to `arrow/benches/sort_kernel.rs`, mirroring the
existing `sort string_view` cases. Reuse the `create_string_view_array*`
helpers from `bench_util` — no new helpers.
### Describe alternatives you've considered
None. This is straightforward coverage for an already-shipped path.
### Additional context
I have a PR ready that implements this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
