Jefffrey commented on code in PR #10600:
URL: https://github.com/apache/arrow-rs/pull/10600#discussion_r3745662438
##########
arrow/benches/sort_kernel.rs:
##########
@@ -318,6 +318,32 @@ fn add_benchmark(c: &mut Criterion) {
c.bench_function("rank string[10] nulls 2^12", |b| {
b.iter(|| hint::black_box(rank(&arr, None).unwrap()))
});
+
+ // `Utf8View` takes the `byte_view_rank` path added in #10559, which reads
+ // values from the view layout rather than the contiguous buffer used by
+ // `bytes_rank` above. These mirror the `sort string_view` benchmarks so
+ // the two kernels stay consistent, and cover the fixed-length and
+ // variable-length shapes that decide how often a value spills out of the
+ // inline prefix into a separate buffer.
Review Comment:
```suggestion
```
its fine to just add the benchmarks with this description
##########
arrow/benches/sort_kernel.rs:
##########
@@ -318,6 +318,32 @@ fn add_benchmark(c: &mut Criterion) {
c.bench_function("rank string[10] nulls 2^12", |b| {
b.iter(|| hint::black_box(rank(&arr, None).unwrap()))
});
+
+ // `Utf8View` takes the `byte_view_rank` path added in #10559, which reads
+ // values from the view layout rather than the contiguous buffer used by
+ // `bytes_rank` above. These mirror the `sort string_view` benchmarks so
+ // the two kernels stay consistent, and cover the fixed-length and
+ // variable-length shapes that decide how often a value spills out of the
+ // inline prefix into a separate buffer.
Review Comment:
```suggestion
```
its fine to just add the benchmarks with this description
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
