pearu commented on PR #50146: URL: https://github.com/apache/arrow/pull/50146#issuecomment-5240905277
Rebased onto current `main` and re-ran the CSV suite locally — `arrow-csv-test` passes 278/278, including the four new `Date32/Date64/Time32/Time64Conversion.UserDefinedParsers` cases. Status recap for whoever picks this up: - Both automated-reviewer comments were addressed in June — `std::ranges::transform` replaced with a plain index loop, and the `%b` locale question answered with a reproducer showing the parsing is locale-independent as written. - The two failing jobs in the last CI run (`AMD64 macOS 15-intel C++` and `Python 3`) were the same Homebrew infrastructure flake — `brew install --formula aws-sdk-cpp` hit a `/usr/local/Cellar/cmake` lock — unrelated to this change. The fresh run on the rebase should clear them. @pitrou — you routed this to @jorisvandenbossche back in June and it has been quiet since. Is there anything I can do to make this easier to review? If reviewing the CSV converter change together with the vendored `strptime` C-locale tables is the sticking point, I'm happy to split the `strptime` part into its own PR. --- _🤖 Drafted by Claude Code (an AI agent) and reviewed & approved by pearu._ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
