zeroshade commented on code in PR #1130:
URL: https://github.com/apache/arrow-go/pull/1130#discussion_r3752141121
##########
arrow/compute/exprs/exec_test.go:
##########
@@ -340,6 +340,11 @@ func TestExecuteFieldRef(t *testing.T) {
}
}
+func TestGetRefFieldEmptySchema(t *testing.T) {
Review Comment:
Minor coverage gap: this pins the top-level empty case, but nothing pins the
nested one. A future refactor that hoists the `len(fields) == 0` check above
the loop would silently drop the `: <type>` detail from nested references and
this test would still pass.
A second case — a reference into a field whose type has no children,
asserting the error still names the type — would guard the behaviour the fix
went out of its way to preserve.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
