Rich-T-kid opened a new pull request, #10614: URL: https://github.com/apache/arrow-rs/pull/10614
# Which issue does this PR close? <!-- We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. --> - Closes #10590 - builds on top of #10591 - works towards https://github.com/apache/datafusion/issues/24111 # Rationale for this change - see #10590 <!-- Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed. Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes. --> # What changes are included in this PR? Optimizes plain-encoded string/binary columns read into Dictionary Arrow arrays by eliminating the intermediate StringArray materialization. Previously, all values were decoded into a flat array first, then iterated again to build the dictionary. Now, hashes are computed upfront in a single batch pass and used to deduplicate values directly into the dictionary output buffers, reducing the work to a single pass over the data. The hash scratch buffer is also reused across batches, so allocation overhead amortizes as batch sizes grow. <!-- There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR. --> # Are these changes tested? yes existing test cover this functionality. nothing logically has changed <!-- We typically require tests for all PRs in order to: 1. Prevent the code from being accidentally broken by subsequent changes 2. Serve as another way to document the expected behavior of the code If tests are not included in your PR, please explain why (for example, are they covered by existing tests)? If this PR claims a performance improvement, please include evidence such as benchmark results. --> # Are there any user-facing changes? yes, `DictionaryBuffer::into_array()` now takes in scratch vector. this is a breaking change <!-- If there are user-facing changes then we may require documentation to be updated before approving the PR. If there are any breaking changes to public APIs, please call them out. --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
