zanmato1984 commented on PR #50501:
URL: https://github.com/apache/arrow/pull/50501#issuecomment-5248435721

   @pitrou Following up on my earlier review comment: with the latest update, 
this feels much closer to the right shape to me. The generic dictionary 
fallback now lives in a dedicated function executor instead of the eager 
`ScalarFunction::Execute` path, while still leaving the existing dispatch 
contract unchanged.
   
   Setting smaller follow-up details aside for the moment, does this look like 
the right overall direction to you now? If not, it would be helpful to 
understand what layer or shape you would prefer before iterating further on the 
implementation.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to