emilk commented on code in PR #10673:
URL: https://github.com/apache/arrow-rs/pull/10673#discussion_r3775058368
##########
parquet/src/arrow/async_reader/mod.rs:
##########
@@ -849,7 +849,6 @@ where
// Push the requested data to the decoder and try again
self.decoder.push_ranges(ranges, data)?;
self.request_state = RequestState::None { input };
- continue; // try and decode on next iteration
Review Comment:
Added back as `// Will try and decode on the next iteration.`, last in the
block.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
##########
parquet/src/arrow/async_reader/mod.rs:
##########
@@ -916,7 +915,6 @@ where
// Push the requested data to the decoder
self.decoder.push_ranges(ranges, data)?;
self.request_state = RequestState::None { input };
- continue; // next iteration will try to decode the
next batch
Review Comment:
Added back as `// The next iteration will try to decode the next batch.`,
last in the block.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
##########
arrow-data/src/equal/list_view.rs:
##########
@@ -81,26 +73,11 @@ pub(super) fn list_view_equal<T: ArrowNativeType + Integer>(
}
} else {
// Need to integrate validity check in the inner loop.
- // non-null pathway: all sizes must be equal, and all values must be
equal
- let lhs_range_sizes = &lhs_sizes[lhs_start..lhs_start + len];
- let rhs_range_sizes = &rhs_sizes[rhs_start..rhs_start + len];
-
+ // The sizes are not compared here: they can differ where the value is
null.
Review Comment:
Dropped.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
