kou commented on code in PR #50547:
URL: https://github.com/apache/arrow/pull/50547#discussion_r3780309579


##########
.github/workflows/cpp_extra.yml:
##########
@@ -122,6 +122,14 @@ jobs:
               -e CMAKE_CXX_STANDARD=23
             runs-on: ubuntu-latest
             title: AMD64 Debian C++23
+          - envs:
+              - DEBIAN=13

Review Comment:
   Can we remove explicit `DEBIAN=13`?



##########
.github/workflows/cpp_extra.yml:
##########
@@ -122,6 +122,14 @@ jobs:
               -e CMAKE_CXX_STANDARD=23
             runs-on: ubuntu-latest
             title: AMD64 Debian C++23
+          - envs:
+              - DEBIAN=13
+            image: debian-cpp
+            run-options: >-
+              -e ARROW_SIMD_LEVEL=NONE
+              -e CXXFLAGS=-march=x86-64

Review Comment:
   Could you use `ARROW_CXXFLAGS` instead? `ARROW_CXXFLAGS` just appends flags 
to `CMAKE_CXX_FLAGS` instead of overriding it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to