WaterWhisperer commented on code in PR #10680:
URL: https://github.com/apache/arrow-rs/pull/10680#discussion_r3780854342
##########
arrow-flight/src/lib.rs:
##########
@@ -59,9 +60,10 @@ use std::{fmt, ops::Deref};
type ArrowResult<T> = std::result::Result<T, ArrowError>;
+// This code is generated so we don't want to fix any lint violations manually
+#[allow(clippy::allow_attributes)]
Review Comment:
Ref: DataFusion uses the same module-boundary exception for generated Prost
code, leaving the generated file untouched:
https://github.com/apache/datafusion/blob/5f9bacddcd14c227935f62109facafcee7616f7c/datafusion/proto-common/src/generated/mod.rs#L18-L22
##########
arrow-flight/tests/common/fixture.rs:
##########
@@ -41,6 +41,7 @@ pub struct TestFixture {
impl TestFixture {
/// create a new test fixture from the server
+ #[expect(clippy::allow_attributes)]
Review Comment:
Ref: DataFusion documents the same `dead_code` lint behavior in its shared
benchmark helper (apache/datafusion#18881, Example 1) and retains the same
attribute pair:
https://github.com/apache/datafusion/blob/186f96fba6b023c8e7310314bb891124e915abc7/datafusion/core/benches/data_utils/mod.rs#L37-L41
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
