rok commented on PR #50368: URL: https://github.com/apache/arrow/pull/50368#issuecomment-5293486353
> @rok would it make sense to break down this test into different smallert more focused tests? To me it's quite complex to follow what we are trying to assert in every step of the test but that might just be that I am not familiar enough with this functionality. The idea of `test_assume_timezone` test is to check if [pc.assume_timezone](https://arrow.apache.org/docs/python/generated/pyarrow.compute.assume_timezone.html) is returning the same results as pandas [tz_localize](https://pandas.pydata.org/docs/reference/api/pandas.Series.tz_localize.html). The test varies `nonexistent` and `ambiguous` parameters and combinations of the two. I wouldn't mind if we split it up or clean it up in some other manner. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
