okhsunrog commented on code in PR #10675:
URL: https://github.com/apache/arrow-rs/pull/10675#discussion_r3795381772
##########
arrow-data/src/transform/mod.rs:
##########
@@ -410,6 +410,20 @@ impl<'a> MutableArrayData<'a> {
Self::with_capacities(arrays, use_nulls, Capacities::Array(capacity))
}
+ /// Fallible variant of [MutableArrayData::new].
+ ///
+ /// Unlike [MutableArrayData::new], this does not panic when merging
dictionary
+ /// arrays whose combined values would overflow the dictionary key type.
Instead,
+ /// it returns `Err(ArrowError::DictionaryKeyOverflowError)`, letting
callers
+ /// (e.g. [`interleave`](crate) / `concat`) surface it as a normal error.
Review Comment:
Applied here too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
