Jefffrey commented on code in PR #10707:
URL: https://github.com/apache/arrow-rs/pull/10707#discussion_r3800878708
##########
arrow/benches/cast_kernels.rs:
##########
@@ -238,6 +238,8 @@ fn cast_array(array: &ArrayRef, to_type: DataType) {
fn add_benchmark(c: &mut Criterion) {
let i32_array = build_array::<Int32Type>(512);
let i64_array = build_array::<Int64Type>(512);
+ let i64_decimal32_array: ArrayRef =
Arc::new(Int64Array::from_iter_values(0..512));
+ let i64_decimal32_scaled_array: ArrayRef =
Arc::new(Int64Array::from_value(5_000_000_000, 512));
Review Comment:
do we need these new arrays? can we use the existing `i64_array` above?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
