pdeva commented on PR #828: URL: https://github.com/apache/arrow-rs-object-store/pull/828#issuecomment-5332807512
@alamb Thanks for the reproducer — you are right. I was testing an S3 Express bucket in a regular Availability Zone (`use1-az4`), where AWS publishes the dual-stack zonal endpoint; `use1-atl2-az1` is a Local Zone, where that hostname is not available. Fixed in [`2bc6127`](https://github.com/apache/arrow-rs-object-store/commit/2bc6127abe69c290fd11d852fa3d60cf6a1f2883): - Dual-stack is now opt-in instead of unconditional. The default keeps `https://{bucket}.s3express-{zone}.{region}.amazonaws.com`, so the Local Zone case retains the existing working hostname. - `AWS_USE_DUALSTACK_ENDPOINT=true`, the `use_dualstack_endpoint` config key, or `with_use_dualstack_endpoint(true)` selects the dual-stack hostname. Our staging configuration already sets the standard AWS environment variable, so it retains the dual-stack behavior. - The option is applied consistently to generated regular S3 and S3 Express endpoints; explicitly configured endpoint URLs are left unchanged. - Regression coverage includes the exact `use1-atl2-az1` default case, an opted-in regular AZ, path-style and virtual-hosted S3 endpoints, and explicit endpoint overrides. Validated with the AWS test suite, the all-provider test/doctest configuration, both `aws` and `aws-base` clippy configurations, rustdoc, and formatting. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
