kowanietz opened a new pull request, #10773: URL: https://github.com/apache/arrow-rs/pull/10773
# Which issue does this PR close? - part of #10245 # Rationale for this change Replacing `BufferBuilder` with `Vec` improves the performance of the dynamic fixed-size binary take path. # What changes are included in this PR? Replaces the remaining `BufferBuilder<u8>` in `take_fixed_size_binary_buffer_dynamic_length` with a `Vec<u8>`. # Are these changes tested? All tests pass: - `cargo fmt --all -- --check` - `cargo clippy -p arrow-select --all-targets --all-features --no-deps -- -D warnings` - `cargo test -p arrow-select --all-features` local benchmark results: | Benchmark | Before | After | Improvement | |---|---:|---:|---:| | Size 12, no null values | 5.0871 µs | 4.5750 µs | 9.99% | | Size 12, 50% null values | 6.2656 µs | 5.7102 µs | 8.88% | # Are there any user-facing changes? No. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
