alamb commented on a change in pull request #321:
URL: https://github.com/apache/arrow-rs/pull/321#discussion_r634775773



##########
File path: arrow/src/buffer/mutable.rs
##########
@@ -235,7 +235,7 @@ impl MutableBuffer {
     }
 
     #[inline]
-    pub(super) fn into_buffer(self) -> Buffer {
+    pub fn into_buffer(self) -> Buffer {

Review comment:
       doesn't this change effectively mean that `into_buffer()` can now be 
called from other crates rather than just the parent module?
   
   So in other words this PR adds something to the public API of Arrow. 
   
   cc @jorgecarleitao 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to