rok commented on code in PR #50874:
URL: https://github.com/apache/arrow/pull/50874#discussion_r3843038956
##########
cpp/src/arrow/extension/tensor_extension_array_test.cc:
##########
@@ -269,13 +269,13 @@ TEST_F(TestFixedShapeTensorType,
MetadataSerializationRoundtrip) {
// Validate dim_names member must be an array with string values
CheckDeserializationRaises(ext_type_, storage_type,
R"({"shape":[3,4],"dim_names":"invalid"})",
- "dim_names must be an array, got String");
+ "dim_names must be an array, got string");
CheckDeserializationRaises(ext_type_, storage_type,
R"({"shape":[3,4],"dim_names":[1,2]})",
- "dim_names must contain strings, got Number");
+ "dim_names must contain strings, got number");
CheckDeserializationRaises(ext_type_, storage_type,
R"({"shape":[3,4],"dim_names":[null,null]})",
- "dim_names must contain strings, got Null");
+ "dim_names must contain strings, got null");
}
Review Comment:
```suggestion
CheckDeserializationRaises(
ext_type_, storage_type, R"({"shape":[3,4],"dim_names":[]})",
"Invalid dim_names");
}
```
##########
cpp/src/arrow/extension/tensor_extension_array_test.cc:
##########
@@ -269,13 +269,13 @@ TEST_F(TestFixedShapeTensorType,
MetadataSerializationRoundtrip) {
// Validate dim_names member must be an array with string values
CheckDeserializationRaises(ext_type_, storage_type,
R"({"shape":[3,4],"dim_names":"invalid"})",
- "dim_names must be an array, got String");
+ "dim_names must be an array, got string");
CheckDeserializationRaises(ext_type_, storage_type,
R"({"shape":[3,4],"dim_names":[1,2]})",
- "dim_names must contain strings, got Number");
+ "dim_names must contain strings, got number");
CheckDeserializationRaises(ext_type_, storage_type,
R"({"shape":[3,4],"dim_names":[null,null]})",
- "dim_names must contain strings, got Null");
+ "dim_names must contain strings, got null");
}
Review Comment:
And the same for VariableShapeTensor.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
