kazuk opened a new pull request #326:
URL: https://github.com/apache/arrow-rs/pull/326


   # Which issue does this PR close?
   
   Closes #315.
   
   # Rationale for this change
    
   
   # What changes are included in this PR?
   
   `Reader::from_reader`  split into `Reader::build_csv_reader`, 
`Reader::from_csv_reader`.
   
   `Reader::build_csv_reader` builds `csv_crate::Reader`,with all CSV reader 
options.
   `Rader::from_csv_reader` builds `arrow::csv::reader::Reader` for 
`csv_crate::Reader`.
   
   add fn `infer_file_schema_with_csv_options` .
   
    change  `infer_file_schema` calls  `infer_file_schema_with_csv_options` 
with default options.
   
   add fn `infer_reader_schema_with_csv_options`.
     change `infer_reader_schema` calls `infer_reader_schema` with default 
options.
   
   add `escape` `quote` `terminator` to `ReaderBuilder`
   
   `ReaderBuilder::build` uses added options.
   
   
   # Are there any user-facing changes?
   
   currently minimized API change.
   
   - add fn `ReaderBuilder::escape`
   - add fn `ReaderBuilder::quote`
   - add fn `ReaderBuilder::terminator`
   
    please concider make public for fn `infer_file_schema_with_csv_options`, 
`infer_reader_schema_with_csv_options` , `Reader::build_csv_reader` , 
`Reader::from_csv_reader`.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to