vikrantpuppala commented on code in PR #50853: URL: https://github.com/apache/arrow/pull/50853#discussion_r3847016456
########## cpp/src/arrow/flight/sql/odbc/odbc_impl/odbc_descriptor_test.cc: ########## Review Comment: The tricky part is SQL_DESC_NAME can't be exercised through a public entry point. I had tried a black-box test via SQLGetStmtAttr(SQL_ATTR_APP_ROW_DESC) + SQLSetDescField(ard, 1, SQL_DESC_NAME, …), but that path returns SQL_ERROR (the field isn't settable on the ARD through the DM), so the only way to reach ODBCDescriptor::SetField(SQL_DESC_NAME) is a direct unit test on ODBCDescriptor. There's no existing descriptor unit test in odbc_impl/ to merge into, and the unit tests there follow a 1:1 source↔test naming convention (util.cc↔util_test.cc, json_converter.cc↔json_converter_test.cc, etc.), so odbc_descriptor_test.cc fit that pattern. Happy to fold it elsewhere if you'd prefer though, e.g. into util_test.cc. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
