adamreeve commented on code in PR #10831:
URL: https://github.com/apache/arrow-rs/pull/10831#discussion_r3849660850
##########
parquet/src/arrow/array_reader/byte_array_dictionary.rs:
##########
@@ -119,11 +123,47 @@ pub fn make_byte_array_dictionary_reader(
}
}
+/// Convert a dictionary-typed array with string or binary typed values
+/// to one with string or binary view typed values.
+fn convert_values_to_view(array: ArrayRef, to_type: &ArrowType) ->
Result<ArrayRef> {
Review Comment:
`DictionaryBuffer` only works with an `OffsetBuffer`, not a `ViewBuffer`, so
this extra conversion step is required:
https://github.com/apache/arrow-rs/blob/3577093f26591aee806a9133c891b6b8e5255477/parquet/src/arrow/buffer/dictionary_buffer.rs#L42
Maybe `DictionaryBuffer` could be refactored to avoid this or a new flavour
of `DictionaryBuffer` could be created that works with view types, but that
seems like it would be a much more complex change. This probably isn't too
performance sensitive as it only needs to convert the dictionary values.
I'm happy to look into making this work without the extra copy if we think
that's needed though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
