EmilyMatt commented on PR #10833: URL: https://github.com/apache/arrow-rs/pull/10833#issuecomment-5424531944
> ``` > arrow_ipc_stream_writer/StreamEncoder/encode_10/dict 1.19 66.4±0.47µs ? ?/sec 1.00 55.8±0.37µs ? ?/sec > ``` > > > ``` > arrow_ipc_stream_writer/StreamEncoder/encode_10/dict 1.22 67.1±0.77µs ? ?/sec 1.00 55.0±0.42µs ? ?/sec > ``` > > the benchmark its self looks fine so i dont think this is noise - > > https://github.com/apache/arrow-rs/blob/2a82e5920421693d5a1c9419f3651cd95d80e37f/arrow-ipc/benches/ipc_writer.rs#L119 I'm not really sure how to address this, running those locally shows 10% up to 20% better perf on this branch, which checks out looking at the code itself. so I'm not sure what to do regarding the CI. Will look into it some more but would appreciate any pointers. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
