Copilot commented on code in PR #50979: URL: https://github.com/apache/arrow/pull/50979#discussion_r3863687228
########## cpp/cmake_modules/ThirdpartyToolchain.cmake: ########## @@ -1175,22 +1177,27 @@ function(build_boost) target_compile_definitions(boost_mpl INTERFACE "BOOST_MPL_CFG_NO_PREPROCESSED_HEADERS") if(ARROW_BOOST_NEED_MULTIPRECISION) - if(ARROW_ENABLE_THREADING) - target_link_libraries(boost_headers INTERFACE Boost::multiprecision) - else() + set(ARROW_BOOST_MULTIPRECISION_TARGET boost_multiprecision) + if(NOT ARROW_ENABLE_THREADING) Review Comment: The multiprecision target is now initialized as `boost_multiprecision`, but the rest of this function consistently uses the exported `Boost::…` targets (and the prior logic linked `Boost::multiprecision`). If `boost_multiprecision` is not defined by the vendored Boost CMake build, this will break bundled builds when ARROW_BOOST_NEED_MULTIPRECISION is ON. Prefer the canonical `Boost::multiprecision` target and override only for the standalone no-threading case. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
