Rich-T-kid commented on code in PR #10840:
URL: https://github.com/apache/arrow-rs/pull/10840#discussion_r3864195894
##########
arrow-schema/src/datatype_display.rs:
##########
@@ -174,10 +174,13 @@ impl Display for DataType {
}
Self::RunEndEncoded(run_ends_field, values_field) => {
write!(f, "RunEndEncoded(")?;
- let run_ends_str = format_field(run_ends_field);
let values_str = format_field(values_field);
- write!(f, "{run_ends_str}, {values_str})")?;
+ write!(
Review Comment:
> RunEndEncoded(Int32, non-null String)
looks cleaner than the alternative.
> and then we expand to the verbose form if we have different names for the
fields,
what would be the use cases of building a REE with a slightly different
name. I'll include this in the PR but im not sure that this code path would be
hit.
> another thing to consider is would this new format roundtrip through
parsing? i dont know if we have existing 100% guarantee that all formatted
displays can also be parsed, but maybe thats something we should aim for
ill check. if its relatively small ill try and fit them into one PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
