fallintoplace opened a new pull request, #1224: URL: https://github.com/apache/arrow-go/pull/1224
## What does this change? - `concat` used to build a temporary `[]bitmap` for each bitmap it concatenated. - `concatBitmaps` now reads the input `ArrayData` directly by buffer index. - Keep the existing nil bitmap behavior for all-valid inputs and preserve sliced bitmap offsets. ## Benchmark Command: ```text go test ./arrow/array -run '^$' -bench '^BenchmarkConcatenateBitmaps$' -benchmem -benchtime=200ms -count=3 ``` Apple M1 Pro, Go 1.26.3. The benchmark concatenates 65,536 rows split across 64, 1,024, and 8,192 chunks. | Input | Chunks | Before ns/op | After ns/op | Before B/op | After B/op | Allocs before/after | | --- | ---: | ---: | ---: | ---: | ---: | ---: | | nullable Boolean | 64 | 6,965 | 5,689 | 25,824 | 20,448 | 10 / 8 | | nullable Boolean | 1,024 | 55,375 | 41,568 | 119,648 | 37,728 | 10 / 8 | | nullable Boolean | 8,192 | 412,768 | 276,285 | 805,730 | 150,368 | 10 / 8 | | nullable int32 | 8,192 | 313,516 | 269,165 | 738,913 | 411,233 | 9 / 8 | ## Tests - `go test ./arrow/array -count=1` - `go test ./arrow/... ./internal/...` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
