fallintoplace opened a new pull request, #1240: URL: https://github.com/apache/arrow-go/pull/1240
## What - Use unchecked offset writes after `Reserve` in `BinaryBuilder.AppendValues`. - Use unchecked payload copies after `ReserveData`. - Apply the same path to `AppendStringValues`. - Keep scalar appends unchanged. - Make `Reserve` cover the terminal offset when the builder has already grown its minimum capacity. - Keep the current physical payload layout for null entries. - Add mixed validity coverage and benchmarks for Binary, LargeBinary, String, and LargeString. ## Benchmark Apple M1 Pro, 65,536 values x 4 bytes, representative run: | Builder | Before | After | Change | | --- | ---: | ---: | ---: | | Binary | 545 us | 473 us | -13% | | LargeBinary | 584 us | 535 us | -8% | Allocations stayed at 9 per operation. ## Tests - `PARQUET_TEST_DATA=parquet-testing/data go test ./...` - `go test -race ./arrow/array -count=1` - `go test -tags=assert ./arrow/array -count=1` - `go vet ./arrow/array` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
