zeroshade commented on PR #1256: URL: https://github.com/apache/arrow-go/pull/1256#issuecomment-5457836107
Checked how this composes with #1172, since both touch `fixed_len_byte_array_decoder.go`. They merge cleanly with no conflict (`prepareOutput` and `spacedExpandSwap` are independent), and the merged result passes `parquet/internal/encoding`, `parquet/file`, and `parquet/pqarrow` in full, including both PRs' own test sets. Allocation behaviour for `DecodeSpaced` on 4096 slots / 3511 values / width 16: | | allocs/op | correct? | | --- | --- | --- | | `main` today | 0 | **no** | | `main` + this PR | 16 | yes | | #1172 + this PR | **0** | yes | So the two are complementary rather than competing: #1172's contiguous cold-output block absorbs the entries that need storage, and `spacedExpandSwap` preserves every header so the steady state needs no allocation at all. Either merge order works. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
