winklemad commented on PR #1219: URL: https://github.com/apache/arrow-go/pull/1219#issuecomment-5458266919
Thanks @zeroshade — you're exactly right, the overflow check was still measuring the unclamped physical run end. Fixed in 300dbe3: I compute the clamped final run end once up front (`min(normalized physical end, input.Len())`) and use it for **both** the overflow check and the written final run end (the raw write could otherwise overshoot/wrap before the post-clamp could catch it). Your repro now passes — an `int16` prefix of 32,760 followed by a one-element slice of a physical 32,767-length run returns length 32,761 instead of the false overflow. Added `TestConcatRunEndEncodedNearTypeLimitSlice` for that boundary; the existing RunEndEncoded tests and the full `arrow/array` suite stay green. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
