sdf-jkl commented on PR #10114: URL: https://github.com/apache/arrow-rs/pull/10114#issuecomment-5540941987
thanks @klion26, I think we need to work on some benchmarks before proceeding. - The existing `cast_kernels` bench doesn't cover the temporal -> utf8 path touched in this PR. - We should also benchmark `variant_get/shred_variant` on string/binary types to see if there are any regressions to avoid https://github.com/apache/arrow-rs/issues/10906 situations. The existing `variant_get/shred_variant` benchmarks don't cover it, so we should add them. I will file the tickets to track this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
