sdf-jkl opened a new issue, #10988:
URL: https://github.com/apache/arrow-rs/issues/10988

   ### Is your feature request related to a problem or challenge?
   
   `parquet-variant-compute/benches/variant_kernels.rs` currently benchmarks:
   
   - Untyped extraction from an unshredded primitive Variant array
   - Typed extraction from a perfectly shredded UTF-8 array
   - Typed `Int32` extraction through a path in an unshredded object
   
   It does not benchmark typed conversion of unshredded Variant values. 
Therefore, the benchmark suite cannot evaluate performance changes to these 
conversion paths or detect regressions introduced while aligning `variant_get` 
behavior with the Arrow cast kernels.
   
   ### Describe the solution you'd like
   
   Add representative benchmarks for typed, unshredded `variant_get`.
   
   The benchmarks should be organized around materially different execution 
paths and input shapes rather than creating a cross-product of Variant types 
and Arrow destination types.
   
   Initial coverage should include the UTF-8 and Binary destination paths, with 
representative inputs that distinguish:
   
   - Values that can be extracted directly
   - Values that require conversion or formatting
   - Nested values such as lists and objects
   
   Inputs should be deterministic and large enough to produce stable 
measurements. Benchmark throughput should be reported alongside iteration time.
   
   Add the benchmarks in a benchmark-only PR so they can be merged and used to 
compare the existing and proposed implementations.
   
   ### Describe alternatives you've considered
   
   ### Additional context
   
   The existing benchmark suite contains useful controls for untyped 
extraction, perfect shredding, and path traversal. The new cases should 
complement those controls rather than duplicate them.
   
   This came up while reviewing #10114.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to