ennuite commented on code in PR #1282:
URL: https://github.com/apache/arrow-java/pull/1282#discussion_r3937246817
##########
flight/flight-core/src/main/java/org/apache/arrow/flight/grpc/NettyClientBuilder.java:
##########
@@ -140,9 +140,9 @@ public NettyChannelBuilder build() {
case LocationSchemes.GRPC_TLS:
{
final int port = location.getUri().getPort();
- if (port < 0 || port > 65535) {
+ if (port < 1 || port > 65535) {
throw new IllegalArgumentException(
- "Invalid port " + port + ": must be between 0 and 65535.");
+ "Invalid port " + port + ": must be between 1 and 65535.");
Review Comment:
I updated the Javadoc for both methods: `NettyClientBuilder.build()` and
`FlightClient.Builder.build()`
Thanks for the review!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
