ax1s-x1zz commented on PR #11006: URL: https://github.com/apache/arrow-rs/pull/11006#issuecomment-5563025887
Thanks for checking Spark and DuckDB behavior — good data point. My reasoning for keeping this scoped: the arrow-rs interval parser is explicitly documented to match PostgreSQL's interval parser (`split_interval_components` doc comment references postgres datetime.c), and this exact case (`"5 day hour"` → `"5 day 0 hour"`) was raised by the author of the current parser in #6390, and confirmed by the DataFusion PR #12448 that depends on it. Since Arrow/DataFusion follow Postgres rather than Spark/DuckDB for interval semantics, matching Postgres here is consistent with the parser's stated contract. That said, I hear the concern that it "reads like a mistake". I've tightened the scope so the relaxation only applies to a *bare unit with a unit present* — `""` stays invalid, unknown/repeated units stay errors. If you'd still prefer the stricter behavior, alternatives are: 1. only allow a bare unit as zero when it is trailing (e.g. `"5 day hour"` ok, `"1 month hour 2 days"` errors), or 2. keep the current behavior and close the issue as a wont-fix. Happy to adjust either way. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
