jonkeane commented on code in PR #50367:
URL: https://github.com/apache/arrow/pull/50367#discussion_r3952842246
##########
r/R/dataset-write.R:
##########
@@ -194,7 +197,7 @@ write_dataset <- function(
path_and_fs <- get_path_and_filesystem(path)
dots <- list(...)
- if (format %in% c("txt", "text") && !any(c("delimiter", "delim") %in%
names(dots))) {
+ if (format == "txt" && !any(c("delimiter", "delim") %in% names(dots))) {
Review Comment:
Does this mean that `"text"` and `"txt"` will behave differently now? As in:
`"text"` will automagically be CSV, but `"txt"` one needs to supply a delimiter
(which might be a comma)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
