Copilot commented on code in PR #47498:
URL: https://github.com/apache/arrow/pull/47498#discussion_r3956069427


##########
python/pyarrow/parquet/core.py:
##########
@@ -1999,7 +2001,9 @@ def write_table(table, where, row_group_size=None, 
version='2.6',
                 use_deprecated_int96_timestamps=None,
                 coerce_timestamps=None,
                 allow_truncated_timestamps=False,
-                data_page_size=None, flavor=None,
+                data_page_size=None,
+                max_rows_per_page=None,
+                flavor=None,

Review Comment:
   The `write_table` signature reorders existing parameters 
(`max_rows_per_page`) and inserts `use_content_defined_chunking` mid-signature. 
Because these are positional-or-keyword parameters, this is a 
backward-incompatible change for any callers using positional arguments (e.g., 
a previously positional `flavor` argument would now bind to 
`max_rows_per_page`). To avoid breaking callers while still exposing the new 
option in generated docs, keep the existing parameter order and append 
`use_content_defined_chunking` at the end (before `**kwargs`).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to