Shockp commented on PR #51109: URL: https://github.com/apache/arrow/pull/51109#issuecomment-5585579728
> This seems to only add a new method so I think it is going to be easier for me to rebase on this in [GH-50629](https://github.com/apache/arrow/pull/50629) than the other way around. > > It seems to me that the new method is not used anywhere here, so I am curious on the use case. I think there may be a small misunderstanding regarding the use of the new method. DecodeAndCount() is used in this PR by the TypedColumnReader::ReadBatch path: TypedColumnReaderImpl::ReadLevels() → ReadDefinitionLevelsAndCount() → LevelDecoder::DecodeAndCount() It replaces the previous definition-level decode followed by a separate std::count() pass. From what I understand, #50629 mainly reworks the RecordReader / Arrow-array path and introduces the bitmap-based optional-field optimization, so the two PRs seem complementary even though they touch some of the same decoder code. I agree that rebasing #50629 on top of this PR sounds easier than the other way around. If there is anything in this API that would make that rebase harder, I'm happy to adjust it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
