Rich-T-kid commented on code in PR #10840:
URL: https://github.com/apache/arrow-rs/pull/10840#discussion_r3958433360
##########
arrow-schema/src/datatype_display.rs:
##########
@@ -173,11 +174,31 @@ impl Display for DataType {
Ok(())
}
Self::RunEndEncoded(run_ends_field, values_field) => {
+ let default_names = run_ends_field.name() ==
Field::REE_RUN_ENDS_FIELD_DEFAULT_NAME
+ && values_field.name() ==
Field::REE_VALUES_FIELD_DEFAULT_NAME;
write!(f, "RunEndEncoded(")?;
- let run_ends_str = format_field(run_ends_field);
- let values_str = format_field(values_field);
-
- write!(f, "{run_ends_str}, {values_str})")?;
+ let re_null = format_nullability(run_ends_field);
+ let v_null = format_nullability(values_field);
+ let v_meta = format_metadata(values_field.metadata());
Review Comment:
https://github.com/apache/arrow-rs/pull/10840/changes/857c98364a50baf435e1248fd0c1553cbd0e3232
adds this but in a slightly different format. the metadata for ree comes right
after the ree field, same for the values. Also added a test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
